Repository navigation
money 0.3.0: publish the Money app (disabled), lanes note, READINESS (#148) - #197
Merged
Merged
Conversation
#148 changed plugin.js's behaviour at 0.2.0: an Imported statements table through destination.tables (atomic-server#1768) and `tables` in config.required, so an importer set up earlier pauses until Set up runs again. Only the manifest version changes here; plugin.js is rebuilt with the README's esbuild line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The money entry gains the drive app's app-module (apps/money/0.3.0/ui.js, written by apps.mjs write) and row names, at the importer's version, with enabled: false for the soft launch. The copy states that a catalog Install does not yet give a working Money app: at the pin it creates a table of its own with no importer, and the importer's table offers under Add view only apps rendering its class. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lane note describes the app test and the known host bug (atomic-server#1846, fixed by #1847 in candidate14 1432e244a). READINESS gets a Money drive app row and the importer row's 0.3.0 statements table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Michiel's decision: a catalog-installed Money app not attaching to the importer's table is handled as part of #177 option 4 (the shared |
This was referenced Sep 29, 2026
READINESS.md conflict: kept #197's matrix (the Bank statements row split into importer and Money drive app rows) and took main's one change to it, the Willow drop row's catalog id (`willow-drop`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lane note, the READINESS Money drive app row and the README's Verified section said the second e2e test can fail on #1846 at the pin. main now pins candidate14 1432e244a, which has atomic-server#1847; both money e2e tests passed once against it on 2026-09-29 (published e2e image). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve integrations/READINESS.md: take main's rewritten matrix (#171: calendar, timesheets, issue-tracker and notion rows) and replace its single Bank statements row with this branch's importer and Money drive app rows. The Money row's label drops `enabled: false` to match main's label style; its install column already says so. Realigned with oxfmt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
marked this pull request as ready for review
September 29, 2026 15:01
# Conflicts: # integrations/READINESS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups for #148. Draft: it waits for #171 (both rewrite READINESS.md and catalog.json) and #179 (the candidate14 pin, which fixes the money e2e's "New app" step, ontola/atomic-server#1846).
tablesa required config key. An importer set up before 0.3.0 therefore pauses until Set up runs again, which is more than a patch.plugin.jswas rebuilt with the README's esbuild command; only its version string changed.moneyentry now also carries the drive app:apps/money/0.3.0/ui.js(88,968 bytes) and its integrity.enabledstaysfalse. The app and the importer share one version, becauseapps.mjsresolves the app by shortname and takes the version fromintegrations/money/package.json.lanes.jsonnote on the money lane, and READINESS rows: the importer at 0.3.0, plus a new row, "Money, drive app (enabled: false)".Known limit, written into the catalog copy, README and READINESS. At pin 2567fc30b, a catalog Install doesn't give a working Money app:
createAppgives the app its own row class and an empty table.renderslists that table's class (useDriveApps.tsappsForClass).store.importer.runrefuses an app that isn't shown as a view of an importer's table.The e2e gets round this by adding the class to
renderstest-side. This looks like what #177's option 4 addresses: views bound to shared row classes,bank-transaction-v1.Checks run locally:
apps.mjs check;🤖 Generated with Claude Code